Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Load and Activate Real Time Commands to SeqN #1543

Merged
merged 7 commits into from
Jan 3, 2025
Merged

Add Load and Activate Real Time Commands to SeqN #1543

merged 7 commits into from
Jan 3, 2025

Conversation

goetzrrGit
Copy link
Contributor

@goetzrrGit goetzrrGit commented Nov 6, 2024 •
edited
Loading

Summary
Added immediate_activate and immediate_load to SeqN.

@IMMEDIATE
ECHO "" 
@LOAD("seqA")

SeqJson

{
  "id": "SeqC",
  "metadata": {},
  "immediate_commands": [
    {
      "args": [
        {
          "type": "string",
          "value": "",
          "name": "echo_string"
        }
      ],
      "stem": "ECHO",
      "type": "command"
    },
    {
      "args": [],
      "sequence": "seqA",
      "type": "load"
    }
  ]
}

@goetzrrGit goetzrrGit requested a review from a team as a code owner November 6, 2024 20:55
@goetzrrGit goetzrrGit requested a review from cohansen November 6, 2024 20:55
@goetzrrGit goetzrrGit self-assigned this Nov 6, 2024
joswig
joswig reviewed Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@joswig joswig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases and functionality are good.

My comment on the seq-json types is because distinct literal values help with control flow analysis. It also feels like we have a lot of type assertions.

src/utilities/sequence-editor/to-seq-json.ts Outdated Show resolved Hide resolved
duranb
duranb requested changes Nov 19, 2024
View reviewed changes
src/utilities/sequence-editor/from-seq-json.ts Outdated Show resolved Hide resolved
src/utilities/sequence-editor/from-seq-json.ts Outdated Show resolved Hide resolved
src/utilities/sequence-editor/from-seq-json.ts Outdated Show resolved Hide resolved
src/utilities/sequence-editor/to-seq-json.ts Outdated Show resolved Hide resolved
@goetzrrGit goetzrrGit force-pushed the feature/load_activate_rtc branch from 32613ac to 684ea67 Compare November 19, 2024 20:03
@goetzrrGit goetzrrGit force-pushed the feature/load_activate_rtc branch from 684ea67 to a7ab412 Compare December 10, 2024 20:54
@goetzrrGit goetzrrGit force-pushed the feature/load_activate_rtc branch from a7ab412 to 4e383b3 Compare December 20, 2024 15:25
@dandelany dandelany mentioned this pull request Dec 20, 2024
Open
@goetzrrGit goetzrrGit force-pushed the feature/load_activate_rtc branch from 4e383b3 to c882421 Compare December 20, 2024 20:40
@goetzrrGit goetzrrGit force-pushed the feature/load_activate_rtc branch from c882421 to 4603932 Compare December 20, 2024 20:56
@goetzrrGit goetzrrGit merged commit a2bed7f into develop Jan 3, 2025
5 checks passed
@goetzrrGit goetzrrGit deleted the feature/load_activate_rtc branch January 3, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermak cartermak cartermak left review comments

@joswig joswig joswig left review comments

@duranb duranb duranb approved these changes

@AaronPlave AaronPlave Awaiting requested review from AaronPlave AaronPlave is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@cohansen cohansen Awaiting requested review from cohansen

Assignees

@goetzrrGit goetzrrGit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goetzrrGit @duranb @joswig @cartermak